From: Al Boldi <a1426z@gawab.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [FIX] ide-io: increase timeout value to allow for slave wakeup
Date: Sun, 23 Apr 2006 14:22:31 +0300 [thread overview]
Message-ID: <200604231422.31176.a1426z@gawab.com> (raw)
In-Reply-To: <20060422214356.0f8afbcb.akpm@osdl.org>
Andrew Morton wrote:
> Al Boldi <a1426z@gawab.com> wrote:
> > Andrew Morton wrote:
> > > Al Boldi <a1426z@gawab.com> wrote:
> > > > During an STR resume cycle, the ide master disk times-out when there
> > > > is also a slave present (especially CD). Increasing the timeout in
> > > > ide-io from 10,000 to 100,000 fixes this problem.
> > > >
> > > > Andrew, do I have to send a patch or can you take care of this
> > > > one-liner?
> > >
> > > Please see the thread "sata suspend resume ..." on this mailing list,
> > > starting Wed, 19 Apr. It sounds like the same thing.
> >
> > Yes, that's what prompted me to look into ide-io.
> > So, will the sata fix also fix ide-io?
>
> Oh. No. Please send a patch.
--- 16/drivers/ide/ide-io.c.orig 2006-03-31 19:12:11.000000000 +0300
+++ 16/drivers/ide/ide-io.c 2006-04-23 13:24:15.000000000 +0300
@@ -932,7 +932,7 @@ static ide_startstop_t start_request (id
printk(KERN_WARNING "%s: bus not ready on wakeup\n", drive->name);
SELECT_DRIVE(drive);
HWIF(drive)->OUTB(8, HWIF(drive)->io_ports[IDE_CONTROL_OFFSET]);
- rc = ide_wait_not_busy(HWIF(drive), 10000);
+ rc = ide_wait_not_busy(HWIF(drive), 100000);
if (rc)
printk(KERN_WARNING "%s: drive not ready on wakeup\n", drive->name);
}
Also apply this one to get rid of this message:
hdb: set_drive_speed_status: status=0x40 { DriveReady }
ide: failed opcode was: unknown
Maybe someone on the ide list can comment on this first though.
--- 16/include/linux/ide.h.orig 2006-03-31 19:12:51.000000000 +0300
+++ 16/include/linux/ide.h 2006-04-23 13:06:32.000000000 +0300
@@ -120,7 +120,7 @@ typedef unsigned char byte; /* used ever
#define IDE_BCOUNTL_REG IDE_LCYL_REG
#define IDE_BCOUNTH_REG IDE_HCYL_REG
-#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==(good))
+#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==((stat)&(good)))
#define BAD_R_STAT (BUSY_STAT | ERR_STAT)
#define BAD_W_STAT (BAD_R_STAT | WRERR_STAT)
#define BAD_STAT (BAD_R_STAT | DRQ_STAT)
next prev parent reply other threads:[~2006-04-23 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-22 20:59 Al Boldi
2006-04-22 21:58 ` Andrew Morton
2006-04-23 4:21 ` Al Boldi
2006-04-23 4:43 ` Andrew Morton
2006-04-23 11:22 ` Al Boldi [this message]
2006-04-24 1:14 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604231422.31176.a1426z@gawab.com \
--to=a1426z@gawab.com \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®