From: Dave Jones <davej@redhat.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Steve French <sfrench@us.ibm.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix cifs breakage when CONFIG_CIFS_EXPERIMENTAL=n
Date: Mon, 24 Apr 2006 16:52:11 -0400 [thread overview]
Message-ID: <20060424205211.GD7385@redhat.com> (raw)
In-Reply-To: <20060424222539.1d3c96fd.khali@linux-fr.org>
On Mon, Apr 24, 2006 at 10:25:39PM +0200, Jean Delvare wrote:
> Hi Steve,
>
> Cifs is currently broken when CONFIG_CIFS_EXPERIMENTAL=n:
>
> The following patch attempts to fix that. Untested beyond compilation.
I fixed it with a smaller equally untested patch:
Signed-off-by: Dave Jones <davej@redhat.com>
fs/cifs/connect.c: In function 'cifs_setup_session':
fs/cifs/connect.c:3451: error: implicit declaration of function 'CIFS_SessSetup'
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.16.noarch/fs/cifs/connect.c~ 2006-04-23 23:08:32.000000000 -0400
+++ linux-2.6.16.noarch/fs/cifs/connect.c 2006-04-23 23:09:45.000000000 -0400
@@ -3447,10 +3447,13 @@ int cifs_setup_session(unsigned int xid,
pSesInfo->server->secMode,
pSesInfo->server->capabilities,
pSesInfo->server->timeZone));
+#ifdef CONFIG_CIFS_EXPERIMENTAL
if(experimEnabled > 1)
rc = CIFS_SessSetup(xid, pSesInfo, CIFS_NTLM /* type */,
- &ntlmv2_flag, nls_info);
- else if (extended_security
+ &ntlmv2_flag, nls_info);
+ else
+#endif
+ if (extended_security
&& (pSesInfo->capabilities & CAP_EXTENDED_SECURITY)
&& (pSesInfo->server->secType == NTLMSSP)) {
cFYI(1, ("New style sesssetup"));
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-04-24 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 20:25 Jean Delvare
2006-04-24 20:52 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060424205211.GD7385@redhat.com \
--to=davej@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome