From: Akinobu Mita <mita@miraclelinux.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [patch 2/4] kref debugging config option
Date: Tue, 25 Apr 2006 12:53:37 +0800 [thread overview]
Message-ID: <20060425045337.GB5698@miraclelinux.com> (raw)
In-Reply-To: <20060424143845.39412304.akpm@osdl.org>
On Mon, Apr 24, 2006 at 02:38:45PM -0700, Andrew Morton wrote:
> Akinobu Mita <mita@miraclelinux.com> wrote:
> >
> > This patch converts all WARN_ON() in kref code to BUG_ON().
>
> Why? This change will irritate testers and will decrease their ability to
> capture (and hence report) diagnostic info.
I have no grudge against this BUG_ON().
But BUG_ON() is more prominent than WARN_ON().
Because I often could not realized whether WARN_ON() happned or not.
Should we make warn_counter which will be increment when WARN_ON()
happens, and export it as /proc/warn-counter? (also export die_counter
as /proc/die-counter) Then I'll make pretty gnome applet.
Or put the shell script which just do "dmesg | grep $warn_on_pattern".
next prev parent reply other threads:[~2006-04-25 4:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 8:33 [patch 0/4] kref debugging Akinobu Mita
2006-04-24 8:33 ` [patch 1/4] kref: warn kref_put() with unreferenced kref Akinobu Mita
2006-04-25 3:51 ` Greg KH
2006-04-25 4:19 ` Valdis.Kletnieks
2006-04-25 5:11 ` Greg KH
2006-04-25 4:34 ` Akinobu Mita
2006-04-25 5:09 ` Greg KH
2006-04-25 6:27 ` Akinobu Mita
2006-04-27 11:45 ` Rogier Wolff
2006-04-24 8:33 ` [patch 2/4] kref debugging config option Akinobu Mita
2006-04-24 21:38 ` Andrew Morton
2006-04-25 4:53 ` Akinobu Mita [this message]
2006-04-25 5:08 ` Greg KH
2006-04-25 3:52 ` Greg KH
2006-04-24 8:33 ` [patch 3/4] dynamic configurable kref debugging Akinobu Mita
2006-04-25 3:55 ` Greg KH
2006-04-24 8:33 ` [patch 4/4] change slab poison pattern Akinobu Mita
2006-04-24 9:20 ` Pekka Enberg
2006-04-24 10:23 ` Akinobu Mita
2006-04-24 15:33 ` Matt Mackall
2006-04-25 3:49 ` [patch 0/4] kref debugging Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060425045337.GB5698@miraclelinux.com \
--to=mita@miraclelinux.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome