Re: [PATCH] off-by-1 in kernel/power/main.c

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > > Valid way to power off machine is by shutdown -o now, and there's a
> > > > syscall to do that. It should not be done by /sys/power/state.
> > > 
> > > hey... my shutdown doesn't have a -o option... where can i find that?
> > 
> > Not sure where I got it, because _my_ shutdown does not have -o,
> > either. Sorry. It has 
> > 
> >        -P     Halt action is to turn off the power.
> > 
> > however. Plus there's a syscall you can use...
> 
> "shutdown -hP now" just causes the machine to power off... i need it to go 
> into S5 -- because it'll only respond to wake-on-lan from S5.  it doesn't 
> respond to WOL after a "shutdown -hP now"...
> 
> ironically the off-by-1 bug let me get into S5... and i thought i had my 
> code working.
> 
> so what i'm really curious about now is the Right Way to go into S5...
> 
> somehow with fc4 "shutdown -h now" put it in S5, but with debian it 
> doesn't... and i haven't figured out yet where the fedora/debian 
> kernel/sysvinit patches differ on this behaviour.

There should not be any difference between S5 and poweroff...

Well, probably driver calls are different in regular case and your
"hacked up" one. Try to find the one that matters...
								Pavel
-- 
Thanks for all the (sleeping) penguins.