mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] -mm: i386 i8259.c simplify i8259A_irq_real()
Date: Thu, 27 Apr 2006 16:34:47 -0700	[thread overview]
Message-ID: <20060427163447.6c6c18a1.akpm@osdl.org> (raw)
In-Reply-To: <20060427221452.GA29019@rhlx01.fht-esslingen.de>

Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
>
> Hello all,
> 
> I noticed the very "non-nice" asymmetry of i8259A_irq_real(),
> so I decided to fix the weirdly aligned branches.
> While doing this, I noticed that it could be streamlined much more,
> resulting in an astonishing 208 byte object code saving for such a tiny code
> fragment! (gcc 3.2.3)

It saves an astonishing two bytes here, with gcc-3.2.1

   text    data     bss     dec     hex filename
   1302     388      10    1700     6a4 arch/i386/kernel/i8259.o

   1300     388      10    1698     6a2 arch/i386/kernel/i8259.o

;)



And with gcc-4.2.0:

bix:/usr/src/25> size arch/i386/kernel/i8259.o
   text    data     bss     dec     hex filename
   1340     356      12    1708     6ac arch/i386/kernel/i8259.o

   1335     356      12    1703     6a7 arch/i386/kernel/i8259.o



      reply	other threads:[~2006-04-27 23:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-27 22:14 Andreas Mohr
2006-04-27 23:34 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060427163447.6c6c18a1.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=andi@rhlx01.fht-esslingen.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®