From: Andrew Morton <akpm@osdl.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: a.zummo@towertech.it, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RTC: rtc-dev tweak for 64-bit kernel
Date: Fri, 28 Apr 2006 23:31:52 -0700 [thread overview]
Message-ID: <20060428233152.4da54d33.akpm@osdl.org> (raw)
In-Reply-To: <20060429.012519.126141613.anemo@mba.ocn.ne.jp>
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>
> Make rtc-dev more friendly to 64-bit platforms with 32-bit userland.
> This tweak is came from genrtc driver.
Please define "friendly". It's not clear what this patch does...
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-dev.c
> index b1e3e61..ae6adc4 100644
> --- a/drivers/rtc/rtc-dev.c
> +++ b/drivers/rtc/rtc-dev.c
> @@ -58,7 +58,7 @@ rtc_dev_read(struct file *file, char __u
> unsigned long data;
> ssize_t ret;
>
> - if (count < sizeof(unsigned long))
> + if (count != sizeof (unsigned int) && count < sizeof (unsigned long))
We normally omit the space between "sizeof" and "(".
next prev parent reply other threads:[~2006-04-29 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 16:25 Atsushi Nemoto
2006-04-29 6:31 ` Andrew Morton [this message]
2006-04-29 13:56 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428233152.4da54d33.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=a.zummo@towertech.it \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®