mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Trefzer <ctrefzer@gmx.de>
To: lkml <linux-kernel@vger.kernel.org>
Subject: [FYI] whitespace removal
Date: Sun, 30 Apr 2006 19:27:16 +0200	[thread overview]
Message-ID: <20060430172716.GC17917@zeus.uziel.local> (raw)

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Hi there,

while fiddling with some driver development I noticed the disturbing
effect of trailing whitespace while comparing functionally different
versions of a driver. Since even git pukes when it encounters some, I
did
	find -type f | xargs sed -e"s/\(\t\|\ \)*$//" -i
on Linus' current git to estimate the dimension of the mess, and the
resulting diff was 25MB in size. Mebibytes, that is (and yuck, what an
un-word). Granted, for one line that has its whitespace removed we get
roughly eight lines in the diff, so this is mostly bloat.

I ended up sending cleanup patches to the maintainers of the external /
internal repository of that driver respectively, but looking at the size
of this "simple" no-op change, I'd rather leave it to driver or
subsystem maintainers to Do The Right Thing in itty bitty steps.

Not trying to be pedantic here, and even less trying to start a flame
war.

Kind regards,
Chris


[-- Attachment #2: Type: application/pgp-signature, Size: 829 bytes --]

             reply	other threads:[~2006-04-30 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-30 17:27 Christian Trefzer [this message]
2006-04-30 17:36 ` Dmitry Fedorov
2006-04-30 17:50   ` Christian Trefzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060430172716.GC17917@zeus.uziel.local \
    --to=ctrefzer@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®