From: Sam Ravnborg <sam@ravnborg.org>
To: Pavel Roskin <proski@gnu.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Removing .tmp_versions considered harmful
Date: Sun, 30 Apr 2006 23:47:32 +0200 [thread overview]
Message-ID: <20060430214732.GB18257@mars.ravnborg.org> (raw)
In-Reply-To: <1145908527.2292.39.camel@dv>
On Mon, Apr 24, 2006 at 03:55:27PM -0400, Pavel Roskin wrote:
> Hello, Sam!
>
> How about following patch? Something needs to be done before 2.6.17.
> Complaints about .tmp_versions are almost in every list about wireless
> drivers I'm subscribed to.
>
> I'm not asking to keep *.mod files, just please keep the .tmp_versions
> directory.
>
> -------------------------------
> Remove *.mod files but not .tmp_versions for external builds
>
> From: Pavel Roskin <proski@gnu.org>
>
> When "make install" is run as root, .tmp_versions is re-created and
> becomes owned by root. Subsequent "make" run by user fails because
> .tmp_versions cannot be removed.
What architecture?
For i386 and x86_64 make install no longer try to compile the kernel.
I have anyway added the following patch:
------------------
Remove *.mod files but not .tmp_versions for external builds
When "make install" is run as root, .tmp_versions is re-created and
becomes owned by root. Subsequent "make" run by user fails because
.tmp_versions cannot be removed.
Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
diff --git a/Makefile b/Makefile
index 6bf9962..8517f7b 100644
--- a/Makefile
+++ b/Makefile
@@ -796,8 +796,8 @@ prepare2: prepare3 outputmakefile
prepare1: prepare2 include/linux/version.h include/asm \
include/config/MARKER
ifneq ($(KBUILD_MODULES),)
- $(Q)rm -rf $(MODVERDIR)
$(Q)mkdir -p $(MODVERDIR)
+ $(Q)rm -f $(MODVERDIR)/*
endif
archprepare: prepare1 scripts_basic
@@ -1086,8 +1086,8 @@ # We are always building modules
KBUILD_MODULES := 1
PHONY += crmodverdir
crmodverdir:
- $(Q)rm -rf $(MODVERDIR)
$(Q)mkdir -p $(MODVERDIR)
+ $(Q)rm -f $(MODVERDIR)/*
PHONY += $(objtree)/Module.symvers
$(objtree)/Module.symvers:
next prev parent reply other threads:[~2006-04-30 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 4:22 Pavel Roskin
2006-04-21 7:32 ` Sam Ravnborg
2006-04-21 11:55 ` Pavel Roskin
2006-04-24 19:55 ` Pavel Roskin
2006-04-24 19:58 ` Arjan van de Ven
2006-04-24 20:19 ` Pavel Roskin
2006-04-30 21:47 ` Sam Ravnborg [this message]
2006-05-01 0:59 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060430214732.GB18257@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®