From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbWEAHnh (ORCPT ); Mon, 1 May 2006 03:43:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751320AbWEAHnh (ORCPT ); Mon, 1 May 2006 03:43:37 -0400 Received: from smtp.osdl.org ([65.172.181.4]:9166 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751319AbWEAHng (ORCPT ); Mon, 1 May 2006 03:43:36 -0400 Date: Mon, 1 May 2006 00:38:33 -0700 From: Andrew Morton To: Adrian Bunk Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC: 2.6 patch] kernel/sys.c: possible cleanups Message-Id: <20060501003833.340ced5b.akpm@osdl.org> In-Reply-To: <20060501073514.GQ3570@stusta.de> References: <20060501071134.GH3570@stusta.de> <20060501001803.48ac34df.akpm@osdl.org> <20060501073514.GQ3570@stusta.de> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Adrian Bunk wrote: > > On Mon, May 01, 2006 at 12:18:03AM -0700, Andrew Morton wrote: > > Adrian Bunk wrote: > > > > > > This patch contains the following possible cleanups: > > > > Please avoid mixing together cleanups > > > > > - proper prototypes for the following functions: > > > - ctrl_alt_del() (in include/linux/reboot.h) > > > - getrusage() (in include/linux/resource.h) > > > - make the following needlessly global functions static: > > > - kernel_restart_prepare() > > > - kernel_kexec() > > > > which I will apply, together with API changes > > Are you splitting the patch yourself or should I send a splitted patch? I currently have queued: drivers/char/hw_random.c: remove assert()'s drivers/char/applicom.c: proper module_{init,exit} fs/buffer.c: possible cleanups fs/open.c: unexport sys_openat So please redo and resend the rest. No particular hurry - I'll be out of the patch business for the next week. > > > - remove the following unused EXPORT_SYMBOL: > > > - in_egroup_p > > > - remove the following unused EXPORT_SYMBOL_GPL's: > > > - kernel_restart > > > - kernel_halt > > > > which I will not. > > > > We have a process for the latter. And even if we ignore that process, the > > patch ends up sitting in -mm for ages because of the API change, along with > > the cleanups, which could be merged up promptly. > > The problem is that we have a lack of a process at the other end: > > There is no process to review added exports. Yes there is - I and many others frequently query them. Sure, sometimes stuff slips through. But it's a very very minor problem.