Re: [PATCH] fs/xfs/xfs_bmap.c: initialize variable, remove warning

[Luca <kronos.it@gmail.com>]

Petri T. Koistinen <petri.koistinen@iki.fi> ha scritto:
> From: Petri T. Koistinen <petri.koistinen@iki.fi>
> 
> Remove warning by initializing uninitialized variable.
> 
> Warning:
>  CC      fs/xfs/xfs_bmap.o
> fs/xfs/xfs_bmap.c: In function 'xfs_bmapi':
> fs/xfs/xfs_bmap.c:2498: warning: 'rtx' is used uninitialized in this function
> 
> Signed-off-by: Petri T. Koistinen <petri.koistinen@iki.fi>
> ---
> fs/xfs/xfs_bmap.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ---
> diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
> index 26939d3..35bad7b 100644
> --- a/fs/xfs/xfs_bmap.c
> +++ b/fs/xfs/xfs_bmap.c
> @@ -2453,7 +2453,7 @@ xfs_bmap_rtalloc(
> 	xfs_extlen_t	prod = 0;	/* product factor for allocators */
> 	xfs_extlen_t	ralen = 0;	/* realtime allocation length */
> 	xfs_extlen_t	align;		/* minimum allocation alignment */
> -	xfs_rtblock_t	rtx;		/* realtime extent number */
> +	xfs_rtblock_t	rtx = 0;	/* realtime extent number */
> 	xfs_rtblock_t	rtb;
> 
> 	mp = ap->ip->i_mount;


Dump compiler ;)

rtx is initialized by xfs_rtpick_extent(); if xfs_rtpick_extent succedes
then rtx is initialized, if it fails then rtx is never used.

I also see the warning, and I'm compiling without CONFIG_XFS_RT; in this
case xfs_rtpick_extent() is a noop (ENOSYS), gcc really should see that
rtx won't be used. Funny.

Luca
-- 
Home: http://kronoz.cjb.net
Il piu` bel momento dell'amore e` quando ci si illude che duri per 
sempre; il piu` brutto, quando ci si accorge che dura da troppo.