From: Nathan Scott <nathans@sgi.com>
To: Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: O_DIRECT, ext3fs, kernel 2.4.32... again
Date: Wed, 3 May 2006 16:35:18 +1000 [thread overview]
Message-ID: <20060503163518.A1929541@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <20060503052752.GA20657@DervishD>; from lkml@dervishd.net on Wed, May 03, 2006 at 07:27:52AM +0200
On Wed, May 03, 2006 at 07:27:52AM +0200, DervishD wrote:
> ...
> Are the differences too large?
Yep.
> I know that this change would be intrusive and probably large,
> but IMHO is a quite important bug, because it prevents apps to
> selectively disable O_DIRECT (the flag is accepted by open(), so
> there's no reason the app should bother about which caused the
> read()/write() failures. In fact, is very difficult to know that
> those failures are caused by partial/buggy support of O_DIRECT flag).
You could open for direct, do a direct read, and see if it fails.
If it fails, clear O_DIRECT on the fd via fcntl(F_SETFL) then do
regular buffered IO instead... a bit hacky, but should work fine
I think.
cheers.
--
Nathan
prev parent reply other threads:[~2006-05-03 6:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 6:32 DervishD
2006-05-01 6:20 ` Marcelo Tosatti
2006-05-01 11:23 ` DervishD
2006-05-01 21:28 ` Nathan Scott
2006-05-01 22:23 ` Bernd Eckenfels
2006-05-02 17:24 ` DervishD
2006-05-02 20:03 ` Nathan Scott
2006-05-03 5:27 ` DervishD
2006-05-03 6:35 ` Nathan Scott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060503163518.A1929541@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®