mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Brent Casavant <bcasavan@sgi.com>
Cc: linux-kernel@vger.kernel.org, pfg@sgi.com, jeremy@sgi.com, jes@sgi.com
Subject: Re: [PATCH] SGI IOC4: Detect IO card variant
Date: Wed, 3 May 2006 19:26:26 -0700	[thread overview]
Message-ID: <20060503192626.1bc3af56.akpm@osdl.org> (raw)
In-Reply-To: <20060503171758.H59683@chenjesu.americas.sgi.com>

On Wed, 3 May 2006 17:21:23 -0500 (CDT)
Brent Casavant <bcasavan@sgi.com> wrote:

> +#ifndef PCI_DEVICE_ID_QLOGIC_ISP12160
> +#define PCI_DEVICE_ID_QLOGIC_ISP12160 0x1216
> +#endif
> +#ifndef PCI_VENDOR_ID_VITESSE
> +#define PCI_VENDOR_ID_VITESSE 0x1725
> +#endif
> +#ifndef PCI_DEVICE_ID_VITESSE_7174
> +#define PCI_DEVICE_ID_VITESSE_7174 0x7174
> +#endif

We shouldn't need the ifdefs here.  Let's just get the right defines in the
right place and use them.

I'm unable to work out whether this problem which this patch fixes warrants
a 2.6.17 merge.


  reply	other threads:[~2006-05-04  2:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03 22:21 Brent Casavant
2006-05-04  2:26 ` Andrew Morton [this message]
2006-05-04 16:44   ` Brent Casavant
2006-05-04 23:51   ` Brent Casavant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060503192626.1bc3af56.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bcasavan@sgi.com \
    --cc=jeremy@sgi.com \
    --cc=jes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pfg@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®