From: Andrew Morton <akpm@osdl.org>
To: Bernhard Rosenkraenzer <bero@arklinux.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>
Subject: Re: [PATCH] 2.6.17-rc3-mm1 breaks AGP on amd64 boxes in 32 bit mode
Date: Wed, 3 May 2006 19:36:50 -0700 [thread overview]
Message-ID: <20060503193650.1a8edf16.akpm@osdl.org> (raw)
In-Reply-To: <200605040033.33579.bero@arklinux.org>
On Thu, 4 May 2006 00:33:33 +0200
Bernhard Rosenkraenzer <bero@arklinux.org> wrote:
> 2.6.17-rc3-mm1 breaks AGP on amd64 boxes in 32 bit mode - a change in the
> related Kconfig file forces the agp-amd64 module to be built only on x86_64,
> simply reverting that bit introduces unresolved symbols k8_nb_ids and
> k8_northbridges (defined but not exported).
Yeah, it turns out that x86 is doing
+k8-y += ../../x86_64/kernel/k8.o
which I failed to spot. This, along with the "amd64" in the name fooled me
into believing that x86 wasn't supposed to be using this code.
x86_64 uses numerous x86 files in this manner, and now we we have x86 using
a couple of x86_64 files in a siilar manner. I think this is a bad thing,
and that we should make all these cross-references operate in the same
direction rather than in both directions. x86_64 developers already have
to deal with this problem, so why make start burdening x86 developers also?
Anyway. Andi, I'll drop x86_64-mm-new-northbridge-fix.patch. Please add
these exports to your copy of x86_64-mm-new-northbridge.patch
next prev parent reply other threads:[~2006-05-04 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 22:33 Bernhard Rosenkraenzer
2006-05-04 2:36 ` Andrew Morton [this message]
2006-05-04 7:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060503193650.1a8edf16.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=bero@arklinux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome