From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Ashok Raj <ashok.raj@intel.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/10] explict migrate tasks for cpu removal
Date: Mon, 8 May 2006 09:16:33 +0200 [thread overview]
Message-ID: <20060508071633.GA10309@elte.hu> (raw)
In-Reply-To: <1147067143.2760.81.camel@sli10-desk.sh.intel.com>
* Shaohua Li <shaohua.li@intel.com> wrote:
> Make cpu_down explictly migrate tasks off dead cpus, this is to fix a
> dead lock in bulk cpu hotremoval (An example of the deadlock is one
> dead cpu is notifing udev the cpu is dead and khelper thread is on
> another dead cpu). Detail info is in the code.
looks good, except some style issues:
> + /* No need to migrate the tasks: it was best-effort if
> + * they didn't do lock_cpu_hotplug(). Just wake up
> + * the requestors. */
needs proper comment style.
> + migration_req_t *req;
> + req = list_entry(rq->migration_queue.next,
> + migration_req_t, list);
missing newline between variables and code.
Ingo
prev parent reply other threads:[~2006-05-08 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-08 5:45 Shaohua Li
2006-05-08 7:16 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060508071633.GA10309@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=shaohua.li@intel.com \
--cc=vatsa@in.ibm.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome