From: Christoph Hellwig <hch@infradead.org>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] BusLogic gcc 4.1 warning fixes
Date: Wed, 10 May 2006 09:26:45 +0100 [thread overview]
Message-ID: <20060510082645.GB18947@infradead.org> (raw)
In-Reply-To: <200605100255.k4A2tuuf031655@dwalker1.mvista.com>
On Tue, May 09, 2006 at 07:55:56PM -0700, Daniel Walker wrote:
> I just commented out BusLogic_AbortCommand because the code that uses it is
> commented out the same way .. It could just be removed .
>
> Fixes the following warnings,
>
> drivers/scsi/BusLogic.c: In function 'BusLogic_init':
> drivers/scsi/BusLogic.c:2302: warning: ignoring return value of 'scsi_add_host', declared with attribute warn_unused_result
> drivers/scsi/BusLogic.c: At top level:
> drivers/scsi/BusLogic.c:2963: warning: 'BusLogic_AbortCommand' defined but not used
this needs real error handling instead of just returning. freeing resources
and so on. similar for the other patches I guess.
next prev parent reply other threads:[~2006-05-10 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:55 Daniel Walker
2006-05-10 8:26 ` Christoph Hellwig [this message]
2006-05-10 10:44 ` Alan Cox
2006-05-10 17:28 Daniel Walker
2006-05-11 17:12 ` Andrew Morton
2006-05-11 20:30 Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510082645.GB18947@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®