From: Adrian Bunk <bunk@stusta.de>
To: Christoph Hellwig <hch@infradead.org>,
Daniel Walker <dwalker@mvista.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] xfs gcc 4.1 warning fixes
Date: Wed, 10 May 2006 16:44:25 +0200 [thread overview]
Message-ID: <20060510144424.GP3570@stusta.de> (raw)
In-Reply-To: <20060510082746.GC18947@infradead.org>
On Wed, May 10, 2006 at 09:27:46AM +0100, Christoph Hellwig wrote:
> On Tue, May 09, 2006 at 07:56:08PM -0700, Daniel Walker wrote:
> > Fixes the following warnings,
> >
> > fs/xfs/xfs_dir.c: In function 'xfs_dir_removename':
> > fs/xfs/xfs_dir.c:363: warning: 'totallen' may be used uninitialized in this function
> > fs/xfs/xfs_dir.c:363: warning: 'count' may be used uninitialized in this function
> >
>
> and so on. that's all false positives. gcc should be fixed here, not xfs.
gcc would need to know that xfs_dir_leaf_lookup_int() in xfs_dir_leaf.c
does never return 0.
This is something gcc can't ever figure out automatically since it's in
a different source file.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-05-10 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:56 Daniel Walker
2006-05-10 8:27 ` Christoph Hellwig
2006-05-10 14:44 ` Adrian Bunk [this message]
2006-05-10 14:52 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510144424.GP3570@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®