From: Mike Kravetz <kravetz@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>, Arnd Bergmann <arnd.bergmann@de.ibm.com>
Cc: penberg@cs.Helsinki.FI, clameter@sgi.com, haveblue@us.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add slab_is_available() routine for boot code
Date: Wed, 10 May 2006 16:00:54 -0700 [thread overview]
Message-ID: <20060510230054.GA11214@w-mikek2.ibm.com> (raw)
In-Reply-To: <20060510155026.173c57a1.akpm@osdl.org>
On Wed, May 10, 2006 at 03:50:26PM -0700, Andrew Morton wrote:
> Mike Kravetz <kravetz@us.ibm.com> wrote:
> > diff -Naupr linux-2.6.17-rc3-mm1/mm/sparse.c linux-2.6.17-rc3-mm1.work3/mm/sparse.c
> > --- linux-2.6.17-rc3-mm1/mm/sparse.c 2006-05-03 22:19:16.000000000 +0000
> > +++ linux-2.6.17-rc3-mm1.work3/mm/sparse.c 2006-05-10 19:15:56.000000000 +0000
> > @@ -32,7 +32,7 @@ static struct mem_section *sparse_index_
> > unsigned long array_size = SECTIONS_PER_ROOT *
> > sizeof(struct mem_section);
> >
> > - if (system_state == SYSTEM_RUNNING)
> > + if (slab_is_available())
> > section = kmalloc_node(array_size, GFP_KERNEL, nid);
> > else
> > section = alloc_bootmem_node(NODE_DATA(nid), array_size);
>
> Is this a needed-for-2.6.17 fix?
I'll let Arnd answer. He ran into this when doing some Cell work. Not
sure where in the development cycle the code is that exposes this bug.
--
Mike
next prev parent reply other threads:[~2006-05-10 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 20:55 Mike Kravetz
2006-05-10 22:50 ` Andrew Morton
2006-05-10 23:00 ` Mike Kravetz [this message]
2006-05-11 3:07 ` Benjamin Herrenschmidt
2006-05-11 12:40 ` Arnd Bergmann
2006-05-11 6:15 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510230054.GA11214@w-mikek2.ibm.com \
--to=kravetz@us.ibm.com \
--cc=akpm@osdl.org \
--cc=arnd.bergmann@de.ibm.com \
--cc=clameter@sgi.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®