From: Andrew Morton <akpm@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH] fs/compat.c: fix 'if (a |= b )' typo
Date: Thu, 11 May 2006 13:33:13 -0700 [thread overview]
Message-ID: <20060511133313.7e3764a4.akpm@osdl.org> (raw)
In-Reply-To: <20060511193754.GD11194@mipter.zuzino.mipt.ru>
Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> Mentioned by Mark Armbrust somewhere on Usenet.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> --- a/fs/compat.c
> +++ b/fs/compat.c
> @@ -1913,7 +1913,7 @@ asmlinkage long compat_sys_ppoll(struct
> }
>
> if (sigmask) {
> - if (sigsetsize |= sizeof(compat_sigset_t))
> + if (sigsetsize != sizeof(compat_sigset_t))
> return -EINVAL;
> if (copy_from_user(&ss32, sigmask, sizeof(ss32)))
> return -EFAULT;
Oh wow. I can only assume that this code leg hasn't been exercised at all.
(I'm a bit surprised that the compiler doesn't warn and demand another set
of parentheses, actually. I guess they decided not to do that for some
reason).
I'll tag this for a 2.6.16 backport, but I'm worried that what we have here
is a pretty significant codepath which just hasn't been executed.
prev parent reply other threads:[~2006-05-11 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 19:37 Alexey Dobriyan
2006-05-11 20:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511133313.7e3764a4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adobriyan@gmail.com \
--cc=drepper@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®