From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Rik Bobbaers <Rik.Bobbaers@cc.kuleuven.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: fix compiler warning in ip_nat_standalone.c
Date: Thu, 11 May 2006 17:55:37 +0200 [thread overview]
Message-ID: <20060511155537.GF1104@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <200605111729.48871.Rik.Bobbaers@cc.kuleuven.be>
On Thu, 11 May 2006 17:29:48 +0200, Rik Bobbaers wrote:
>
> i just made small patch that fixes a compiler warning:
Just in case Al didn't make it clear enough in the recent thread:
You cannot fix a compiler warning!
Either the code is wrong or it is right. A compiler warning can
indicate that code is wrong, or it is a false positive. If the code
is wrong, fix the _code_. If it isn't, ignore the warning or fix the
_compiler_.
That said, your patch looks as if it would actually fix the code. I'm
not firm enough with NAT to confirm that, though. So if it fixes the
code, please state exactly that.
Jörn
--
Anything that can go wrong, will.
-- Finagle's Law
next prev parent reply other threads:[~2006-05-11 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 15:29 Rik Bobbaers
2006-05-11 15:55 ` Jörn Engel [this message]
2006-05-11 16:14 ` Alexey Dobriyan
2006-05-11 16:18 ` Al Viro
2006-05-11 18:35 ` Jörn Engel
2006-05-11 16:49 ` Rik Bobbaers
2006-05-11 18:30 ` Jörn Engel
2006-05-11 16:14 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511155537.GF1104@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=Rik.Bobbaers@cc.kuleuven.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®