From: Zach Brown <zach.brown@oracle.com>
To: Andrew Morton <akpm@osdl.org>, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Add dependency on kernel.release to the package targets
Date: Fri, 12 May 2006 14:34:52 -0700 (PDT) [thread overview]
Message-ID: <20060512213452.2074.84076.sendpatchset@tetsuo.zabbo.net> (raw)
Add dependency on kernel.release to the package targets
The binrpm-pkg target uses KERNELRELEASE when generated its .spec
file. When binrpm-pkg was the first build target run in a tree it
generated the .spec before kernel.release so the Version: tag
in the .spec was empty.
I don't know if this is the best fix, but binrpm-pkg works when we
explicitly build kernel.release before descending into package-dir.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: 2.6.17-rc3-mm1-rds/Makefile
===================================================================
--- 2.6.17-rc3-mm1-rds.orig/Makefile
+++ 2.6.17-rc3-mm1-rds/Makefile
@@ -986,9 +986,9 @@ distclean: mrproper
# rpm target kept for backward compatibility
package-dir := $(srctree)/scripts/package
-%pkg: FORCE
+%pkg: include/config/kernel.release FORCE
$(Q)$(MAKE) $(build)=$(package-dir) $@
-rpm: FORCE
+rpm: include/config/kernel.release FORCE
$(Q)$(MAKE) $(build)=$(package-dir) $@
reply other threads:[~2006-05-12 21:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060512213452.2074.84076.sendpatchset@tetsuo.zabbo.net \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®