Re: [PATCH -mm] swsusp: support creating bigger images (rev. 2)

["Rafael J. Wysocki" <rjw@sisk.pl>]

Hi,

Sorry for the slow response, I've had a lot of work to do recently.

On Friday 12 May 2006 12:30, Pavel Machek wrote:
> > > Too much uncertainity for 10% speedup, I'm afraid. Yes, it was really
> > > clever to get this fundamental change down to few hundred lines, but
> > > design complexity remains. Could we drop that patch?

I think the main problem with the patch was that the criterion by which
the pages were included in the image without copying appeared to be too simple
and therefore too general.  It well might be correct, but that's yet to be
shown.  OTOH it probably is possible to use a criterion that everybody will
agree with.  For example, we could chose pages that would be reclaimed if
there were memory pressure (the pages with I/O operations pending should
not belong to this class).
 
> > Could you provide justification for your claim that the speedup is
> > only 10%?
> 
> 10% was number Rafael provided, IIRC.

That's true, but I only measured the short-time effect of the suspend on the
system responsiveness.

Apart from this without the patch swsusp tends to leave quite o lot
of data in the swap and IMO this effect should not be neglected.  Currently we
only have a very general idea about what these data are and why it happens
actually and there's no warranty it wouldn't hamper performance in the
long run.

> > Please also remember that you are introducing complexity in other ways, with 
> > that swap prefetching code and so on. Any comparison in speed should include 
> > the time to fault back in pages that have been discarded.
> 
> Well, swap prefetching is useful for other workloads, too; so it gets
> developed/tested outside swsusp.

Still my experience indicates that it doesn't play very nice with swsusp and
unfortunately it hogs the I/O.

Greetings,
Rafael