From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Jesper Juhl" <jesper.juhl@gmail.com>,
linux-kernel@vger.kernel.org,
"Jochen Schäuble" <psionic@psionic.de>,
"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH] mtd: fix memory leaks in phram_setup
Date: Sun, 14 May 2006 08:37:31 +0200 [thread overview]
Message-ID: <20060514063731.GA22033@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <1147563643.16761.1.camel@shinybook.infradead.org>
On Sun, 14 May 2006 00:40:42 +0100, David Woodhouse wrote:
> >
> > Want me to fix the macro and the users of it?
>
> Well, the exclamation was intended to provoke Jörn or Jochen into fixing
> it for themselves, but if you get there first that'd be great too :)
The only question is: does it make the code better? The code has
seven printk/return combinations. Each of them would chew up 2 more
lines without the macro. So phram_setup would grow from 44 to 58
lines, not nice either.
What bugs me more is the hidden allocation in parse_name. Looks like
that should return a pointer or ERR_PTR(foo), not an int.
Jörn
--
There are two ways of constructing a software design: one way is to make
it so simple that there are obviously no deficiencies, and the other is
to make it so complicated that there are no obvious deficiencies.
-- C. A. R. Hoare
next prev parent reply other threads:[~2006-05-14 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 23:07 Jesper Juhl
2006-05-13 23:18 ` David Woodhouse
2006-05-13 23:34 ` Jesper Juhl
2006-05-13 23:40 ` David Woodhouse
2006-05-14 6:37 ` Jörn Engel [this message]
2006-05-14 11:03 ` David Woodhouse
2006-05-14 13:21 ` Jörn Engel
2006-05-14 16:37 ` Ingo Oeser
2006-05-14 20:07 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060514063731.GA22033@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=dwmw2@infradead.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=psionic@psionic.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®