From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbWENPbS (ORCPT ); Sun, 14 May 2006 11:31:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751456AbWENPbS (ORCPT ); Sun, 14 May 2006 11:31:18 -0400 Received: from smtprelay01.ispgateway.de ([80.67.18.13]:20660 "EHLO smtprelay01.ispgateway.de") by vger.kernel.org with ESMTP id S1751455AbWENPbR (ORCPT ); Sun, 14 May 2006 11:31:17 -0400 From: Ingo Oeser To: Steven Rostedt Subject: Re: [PATCH -mm] update comment in rtmutex.c and friends Date: Sun, 14 May 2006 17:28:03 +0200 User-Agent: KMail/1.9.1 Cc: akpm@osdl.org, Ingo Molnar , Thomas Gleixner , LKML References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605141728.05752.ioe-lkml@rameria.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On Sunday, 14. May 2006 01:34, Steven Rostedt wrote: > @@ -46,9 +46,15 @@ > * > * The fast atomic compare exchange based acquire and release is only > * possible when bit 0 and 1 of lock->owner are 0. > + * > + * (*) There's a small time where the owner can be NULL and the > + * "lock has waiters" bit is set. This can happen when grabbing the lock. > + * To prevent a cmpxchg of the owner releasing the lock, we need to set this > + * bit before looking at the lock, hence the reason this is a transitional > + * state. > */ > > -static void > +static vid Typo here. > rt_mutex_set_owner(struct rt_mutex *lock, struct task_struct *owner, > unsigned long mask) > { > @@ -365,6 +371,7 @@ static int try_to_take_rt_mutex(struct r PS: Compile testing ANY changes to *.c and *.h files will catch most obvious brown paper bag typos for you :-) Regards Ingo Oeser