mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: "Jaya Kumar" <jayakumar.video@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH/RFC 2.6.16.5 1/1] usb/media/quickcam_messenger driver v2
Date: Mon, 15 May 2006 16:09:47 +0200	[thread overview]
Message-ID: <200605151609.48217.oliver@neukum.org> (raw)
In-Reply-To: <70066d530605150550q55deb127w1ab2a4451b065a54@mail.gmail.com>

Am Montag, 15. Mai 2006 14:50 schrieb Jaya Kumar:
> On 5/15/06, Oliver Neukum <oliver@neukum.name> wrote:
> > Am Montag, 15. Mai 2006 10:49 schrieb jayakumar.video@gmail.com:
> > > +urb->status = 0;
> > > +urb->actual_length = 0;
> >
> > These are not needed. Indeed you should never write to those fields.
> >
> >         Regards
> >                 Oliver
> >
> 
> I see. Good point. I ought to have actually looked at usb_submit_urb
> and seen that it initializes status and actual_length. I'll make the
> change.
> 
> To reduce my embarrassment, I'll point out that several other media
> drivers also do this:
> 
> drivers/usb/media % egrep "urb->status.*=" *.c
> <snip>
> konicawc.c:        urb->status = 0;
> se401.c:        urb->status=0;
> stv680.c:       urb->status = 0;
> usbvideo.c:     urb->status = 0;
> w9968cf.c:      urb->status = 0;
> 
> In most of the above cases, it appears to be just before resubmitting the urb.

There's your opportunity to remove even more unnecessary kernel code.

	Regards
		Oliver

  parent reply	other threads:[~2006-05-15 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-15  8:49 jayakumar.video
2006-05-15 10:35 ` Oliver Neukum
2006-05-15 12:50   ` Jaya Kumar
2006-05-15 13:19     ` Jaya Kumar
2006-05-15 14:09     ` Oliver Neukum [this message]
2006-05-15 10:36 ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200605151609.48217.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=jayakumar.video@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®