From: Vivek Goyal <vgoyal@in.ibm.com>
To: Morton Andrew Morton <akpm@osdl.org>,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
Fastboot mailing list <fastboot@lists.osdl.org>
Cc: Andi Kleen <ak@muc.de>, Don Zickus <dzickus@redhat.com>
Subject: [PATCH] kdump x86_64 nmi event notification fix
Date: Mon, 15 May 2006 13:48:49 -0400 [thread overview]
Message-ID: <20060515174849.GB28981@in.ibm.com> (raw)
o After a crash we should wait for NMI IPI event and not for external NMI
or NMI watchdog tick.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
linux-2.6.17-rc4-1M-vivek/arch/x86_64/kernel/crash.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN arch/x86_64/kernel/crash.c~kdump-x86_64-nmi-event-notification-fix arch/x86_64/kernel/crash.c
--- linux-2.6.17-rc4-1M/arch/x86_64/kernel/crash.c~kdump-x86_64-nmi-event-notification-fix 2006-05-15 13:26:41.000000000 -0400
+++ linux-2.6.17-rc4-1M-vivek/arch/x86_64/kernel/crash.c 2006-05-15 13:27:02.000000000 -0400
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct not
struct pt_regs *regs;
int cpu;
- if (val != DIE_NMI)
+ if (val != DIE_NMI_IPI)
return NOTIFY_OK;
regs = ((struct die_args *)data)->regs;
@@ -114,7 +114,7 @@ static int crash_nmi_callback(struct not
* an NMI if system was initially booted with nmi_watchdog parameter.
*/
if (cpu == crashing_cpu)
- return 1;
+ return NOTIFY_STOP;
local_irq_disable();
crash_save_this_cpu(regs, cpu);
_
reply other threads:[~2006-05-15 17:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060515174849.GB28981@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=dzickus@redhat.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®