From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups
Date: Tue, 16 May 2006 12:27:31 -0700 [thread overview]
Message-ID: <20060516122731.6ecbdeeb.akpm@osdl.org> (raw)
In-Reply-To: <20060516174413.GI10077@stusta.de>
Adrian Bunk <bunk@stusta.de> wrote:
>
> - remove the following unused EXPORT_SYMBOL's:
> - journal_set_features
> - journal_update_superblock
These might be used by lustre - dunno.
But I'm ducking all patches which alter exports, as usual. If you can get
them through the subsystem maintainer then good luck.
I'd suggest that we pursue the approach of getting the module loader to
spit a warning when someone uses a going-away-soon export.
Arjan had a patch which did that, but he removed basically _every_
presently-unused export. I don't think we should do that. If we're
exporting, for example, the kthread API and we happen to notice that
kthread_bind() isn't presently used by any modules then I don't believe it
makes much sense to unexport kthread_bind(). It makes more sense to export
the kthread API as a whole.
next prev parent reply other threads:[~2006-05-16 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 17:44 Adrian Bunk
2006-05-16 19:27 ` Andrew Morton [this message]
2006-05-16 19:39 ` Adrian Bunk
2006-05-16 19:50 ` Andrew Morton
2006-05-18 11:52 ` Stephen C. Tweedie
2006-05-16 21:14 ` Theodore Tso
2006-05-16 21:33 ` Adrian Bunk
2006-05-16 22:26 ` [PATCH] Update ext2/ext3/jbd MAINTAINERS entries Theodore Tso
2006-05-18 11:48 ` Stephen C. Tweedie
2006-05-17 1:33 ` [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups Arjan van de Ven
2006-05-17 1:40 ` Andrew Morton
2006-05-17 1:51 ` Arjan van de Ven
2006-05-17 1:58 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-05-01 7:11 Adrian Bunk
2006-04-23 11:49 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516122731.6ecbdeeb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome