From: Al Viro <viro@ftp.linux.org.uk>
To: Andreas Schwab <schwab@suse.de>
Cc: James Morris <jmorris@namei.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] selinux: endian fix
Date: Tue, 16 May 2006 17:34:26 +0100 [thread overview]
Message-ID: <20060516163426.GF27946@ftp.linux.org.uk> (raw)
In-Reply-To: <jeiro6sztd.fsf@sykes.suse.de>
On Tue, May 16, 2006 at 06:24:14PM +0200, Andreas Schwab wrote:
> James Morris <jmorris@namei.org> writes:
>
> > On Tue, 16 May 2006, Alexey Dobriyan wrote:
> >
> >> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> >
> > Hmm, I'm certain this was tested (perhaps on a BE machine, though).
>
> ntohs and htons are identical operations. Either you swap or you don't,
> but there is only one way to swap a short.
Indeed, but that kind of crap still deserves a fix - same result, but
use that kind of misuse is begging for bugs later on.
next prev parent reply other threads:[~2006-05-16 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 15:23 Alexey Dobriyan
2006-05-16 15:54 ` James Morris
2006-05-16 16:24 ` Andreas Schwab
2006-05-16 16:30 ` James Morris
2006-05-16 16:34 ` Al Viro [this message]
2006-05-16 17:42 ` Jan Engelhardt
2006-05-16 17:50 ` Andreas Schwab
2006-05-17 0:55 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516163426.GF27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®