From: "David S. Miller" <davem@davemloft.net>
To: oleg@tv-sign.ru
Cc: akpm@osdl.org, hch@infradead.org, axboe@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] list: use list_replace_init() instead of list_splice_init()
Date: Wed, 17 May 2006 15:46:33 -0700 (PDT) [thread overview]
Message-ID: <20060517.154633.131645340.davem@davemloft.net> (raw)
In-Reply-To: <20060518014042.GA891@oleg>
From: Oleg Nesterov <oleg@tv-sign.ru>
Date: Thu, 18 May 2006 05:40:42 +0400
> list_splice_init(list, head) does unneeded job if it is known that
> list_empty(head) == 1. We can use list_replace_init() instead.
>
> [ I did list_replace() for use in kernel/timer.c. I am not sure it
> is ok to patch random files at once, but it looks so simple ... ].
>
> arch/i386/mm/pageattr.c | 8 ++++----
> block/ll_rw_blk.c | 5 ++---
> fs/aio.c | 4 ++--
> kernel/timer.c | 8 ++++----
> kernel/workqueue.c | 4 ++--
> net/core/dev.c | 6 +++---
> net/core/link_watch.c | 5 ++---
> 7 files changed, 19 insertions(+), 21 deletions(-)
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2006-05-17 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 1:40 Oleg Nesterov
2006-05-17 22:46 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517.154633.131645340.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®