From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Russell King <rmk@arm.linux.org.uk>,
Andrew Morton <akpm@osdl.org>,
Christoph Hellwig <hch@infradead.org>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [patch 01/50] genirq: cleanup: merge irq_affinity[] into irq_desc[]
Date: Wed, 17 May 2006 10:32:10 +0200 [thread overview]
Message-ID: <20060517083210.GA26456@elte.hu> (raw)
In-Reply-To: <20060517055650.GA19785@mars.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> wrote:
> > +++ linux-genirq.q/arch/powerpc/platforms/pseries/xics.c
> > @@ -238,7 +238,7 @@ static int get_irq_server(unsigned int i
> > {
> > unsigned int server;
> > /* For the moment only implement delivery to all cpus or one cpu */
> > - cpumask_t cpumask = irq_affinity[irq];
> > + cpumask_t cpumask = irq_desc[irq].affinity;
> > cpumask_t tmp = CPU_MASK_NONE;
> >
> > if (!distribute_irqs)
>
> Assigned unconditionally - outside CONFIG_SMP as I read the code but..
> > +#ifdef CONFIG_SMP
> > + cpumask_t affinity;
> > +#endif
> But defined only for SMP. Looks wrong at first look.
but the original array was under SMP too:
--- linux-genirq.q.orig/kernel/irq/manage.c
+++ linux-genirq.q/kernel/irq/manage.c
@@ -16,8 +16,6 @@
#ifdef CONFIG_SMP
-cpumask_t irq_affinity[NR_IRQS] = { [0 ... NR_IRQS-1] = CPU_MASK_ALL };
so if then this is a powerpc bug. (probably pseries is rarely built
without SMP support)
Ingo
prev parent reply other threads:[~2006-05-17 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 0:13 Ingo Molnar
2006-05-17 5:56 ` Sam Ravnborg
2006-05-17 8:32 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517083210.GA26456@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®