mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org, gallatin@myri.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] myri10ge - Driver header files
Date: Wed, 17 May 2006 15:28:17 -0700	[thread overview]
Message-ID: <20060517152817.58a6d8bc.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060517220434.GC13411@myri.com>

On Wed, 17 May 2006 18:04:35 -0400 Brice Goglin wrote:

> [PATCH 2/4] myri10ge - Driver header files
> 
>  myri10ge_mcp.h            |  205 ++++++++++++++++++++++++++++++++++++++++++++++
>  myri10ge_mcp_gen_header.h |   58 +++++++++++++

Please use "diffstat -p 1 -w 70" is documented in
Documentation/SubmittingPatches.

>  2 files changed, 263 insertions(+)
> 
> --- /dev/null	2006-05-16 20:08:50.920483500 +0200
> +++ linux-tmp//drivers/net/myri10ge/myri10ge_mcp.h	2006-05-17 11:02:48.000000000 +0200
> @@ -0,0 +1,205 @@
> +#ifndef __MYRI10GE_MCP_H__
> +#define __MYRI10GE_MCP_H__
> +
> +#define MYRI10GE_MCP_VERSION_MAJOR	1
> +#define MYRI10GE_MCP_VERSION_MINOR	4
> +
> +/* 16 Bytes */

What is 16 bytes here?

> +struct mcp_slot {
> +	u16 checksum;
> +	u16 length;
> +};


---
~Randy

  reply	other threads:[~2006-05-17 22:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-17 22:02 [PATCH 0/4] myri10ge - Myri-10G Ethernet driver - v2 Brice Goglin
2006-05-17 22:03 ` [PATCH 1/4] myri10ge - Revive pci_find_ext_capability Brice Goglin
2006-05-17 22:04 ` [PATCH 2/4] myri10ge - Driver header files Brice Goglin
2006-05-17 22:28   ` Randy.Dunlap [this message]
2006-05-18 23:36     ` Brice Goglin
2006-05-17 22:06 ` [PATCH 3/4] myri10ge - Driver core Brice Goglin
2006-05-17 22:36   ` Roland Dreier
2006-05-18 23:38     ` Brice Goglin
2006-05-17 23:08   ` Arnd Bergmann
2006-05-18 23:56     ` Brice Goglin
2006-05-19  1:55       ` Arnd Bergmann
2006-05-19  2:25         ` Brice Goglin
2006-05-19 10:00           ` Arnd Bergmann
2006-05-19 11:09             ` Andi Kleen
2006-05-19 15:48               ` Brice Goglin
2006-05-20  7:58                 ` Brice Goglin
2006-05-19 14:39     ` Brice Goglin
2006-05-19 23:15     ` Brice Goglin
2006-05-20  0:01       ` Andi Kleen
2006-05-23 15:39   ` Anton Blanchard
2006-05-24  8:04     ` Brice Goglin
2006-05-24 21:21       ` Anton Blanchard
2006-05-25  7:59       ` Benjamin Herrenschmidt
2006-05-25  9:07         ` Brice Goglin
2006-05-25  7:56     ` Benjamin Herrenschmidt
2006-05-26  9:49       ` Ingo Oeser
2006-05-26 10:02         ` Benjamin Herrenschmidt
2006-05-26 10:30           ` Jeff Garzik
2006-05-26 10:56             ` Benjamin Herrenschmidt
2006-05-17 22:07 ` [PATCH 4/4] myri10ge - Kconfig and Makefile Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517152817.58a6d8bc.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=brice@myri.com \
    --cc=gallatin@myri.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®