mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: dgc@sgi.com, Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
	nickpiggin@yahoo.com.au, clameter@sgi.com, pj@sgi.com
Subject: Re: [PATCH 01/03] Cpuset: might sleep checking zones allowed fix
Date: Wed, 17 May 2006 22:25:43 -0700	[thread overview]
Message-ID: <20060517222543.600cb20a.akpm@osdl.org> (raw)
In-Reply-To: <20060518043556.15898.73616.sendpatchset@jackhammer.engr.sgi.com>

Paul Jackson <pj@sgi.com> wrote:
>
> Fix a couple of infrequently encountered 'sleeping function
>  called from invalid context' in the cpuset hooks in
>  __alloc_pages.  Could sleep while interrupts disabled.

I'd have thought that if all the callers get their __GFP_HARDWALLS correct
then that fishy-looking in_interrupt() test in __cpuset_zone_allowed()
could be removed?

  parent reply	other threads:[~2006-05-18  5:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18  4:35 Paul Jackson
2006-05-18  4:36 ` [PATCH 02/03] Cpuset: update cpuset_zones_allowed comment Paul Jackson
2006-05-18  4:36 ` [PATCH 03/03] Cpuset: might_sleep_if check in cpuset_zones_allowed Paul Jackson
2006-05-18  5:25 ` Andrew Morton [this message]
2006-05-18  5:47   ` [PATCH 01/03] Cpuset: might sleep checking zones allowed fix David Chinner
2006-05-19  0:48     ` Paul Jackson
2006-05-19  2:21       ` David Chinner
2006-05-19  3:12         ` Paul Jackson
2006-05-19  8:54           ` David Chinner
2006-05-19  0:58   ` Paul Jackson
2006-05-19  1:10     ` Christoph Lameter
2006-05-19  1:26       ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517222543.600cb20a.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Simon.Derr@bull.net \
    --cc=clameter@sgi.com \
    --cc=dgc@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome