From: Ingo Molnar <mingo@elte.hu>
To: john stultz <johnstul@us.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][-rt PATCH] Try to safely error out when mixing pi/non-pi futex operations on the same futex.
Date: Thu, 18 May 2006 09:58:10 +0200 [thread overview]
Message-ID: <20060518075810.GB30387@elte.hu> (raw)
In-Reply-To: <1147900129.9363.7.camel@localhost.localdomain>
* john stultz <johnstul@us.ibm.com> wrote:
> Ingo,
> We've been seeing some oopses because there are waiters on pi
> futexes that do not have pi_states. This seems to be because they were
> used w/ futex_wait in one path and futex_lock_pi in another.
indeed, that's a bug.
> I'm told this shouldn't ever happen, but if it did, the kernel should
> safely error out, instead of oopsing or never releasing a lock.
>
> Not sure if this is a solid fix (it does build and boot), but
> hopefully it will stir up some discussion.
applied. I made some small fixes: i made the printk rate-limited and
dependent on CONFIG_DEBUG_RT_MUTEXES. The right thing is indeed to
-EINVAL.
Ingo
prev parent reply other threads:[~2006-05-18 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 21:08 john stultz
2006-05-18 7:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060518075810.GB30387@elte.hu \
--to=mingo@elte.hu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®