From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@suse.cz>
Cc: dtor_core@ameritech.net, linux-input@atrey.karlin.mff.cuni.cz,
vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [patch] fix magic sysrq on strange keyboards
Date: Thu, 18 May 2006 12:10:57 -0700 [thread overview]
Message-ID: <20060518121057.3d79779b.akpm@osdl.org> (raw)
In-Reply-To: <20060518102354.GA1715@elf.ucw.cz>
Pavel Machek <pavel@suse.cz> wrote:
>
> Magic sysrq fails to work on many keyboards, particulary most of
> notebook keyboards. This should help...
>
> The idea is quite simple: Discard the SysRq break code if Alt is still
> being held down. This way the broken keyboard can send the break code
> (or the user with a normal keyboard can release the SysRq key) and the
> kernel waits until the next key is pressed or the Alt key is released.
>
> From: Fredrik Roubert <roubert@df.lth.se>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
What kernel are you patching here?
> index 5d84839..4602cf3 100644
> --- a/drivers/char/keyboard.c
> +++ b/drivers/char/keyboard.c
> @@ -149,7 +149,8 @@ unsigned char kbd_sysrq_xlate[KEY_MAX +
> "\206\207\210\211\212\000\000789-456+1" /* 0x40 - 0x4f */
> "230\177\000\000\213\214\000\000\000\000\000\000\000\000\000\000" /* 0x50 - 0x5f */
> "\r\000/"; /* 0x60 - 0x6f */
> -static int was_sysrq;
> +static int sysrq_down;
> +static int sysrq_alt_use;
bix:/usr/src/linux-2.6.17-rc4> grep was_sysrq drivers/char/sysrq.c
bix:/usr/src/linux-2.6.17-rc4>
next prev parent reply other threads:[~2006-05-18 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 10:23 Pavel Machek
2006-05-18 19:10 ` Andrew Morton [this message]
2006-05-18 21:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060518121057.3d79779b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®