mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: linux-kernel@vger.kernel.org, ppisa4lists@pikron.com
Subject: Re: Was this really supposed to go in?
Date: Sat, 20 May 2006 16:45:59 +0100	[thread overview]
Message-ID: <20060520154558.GB16679@flint.arm.linux.org.uk> (raw)
In-Reply-To: <446F3788.8050105@drzeus.cx>

On Sat, May 20, 2006 at 05:36:40PM +0200, Pierre Ossman wrote:
> Commit 2c171bf13423dc5293188cea7f6c2da1720926e2 in Linus' tree seems
> strange. It includes more changes than Pavel's original patch, but with
> the same commit message.

They shouldn't have gone in - they were a change I was working on a few
days ago which I left in the git tree uncommitted.  Applying Pavel's
patch then committed them.

> Also, I think the extra changes are broken as we then would have two
> parameters that have that contain the same information, yet the do not
> have the same ranges.

It's part of transitioning the data transfers over to taking the byte
size instead of the log2 byte size.

Well, I can't do anything about it now - I'm going away for a couple
of weeks from tomorrow morning.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2006-05-20 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-20 15:36 Pierre Ossman
2006-05-20 15:45 ` Russell King [this message]
2006-05-20 15:49   ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060520154558.GB16679@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ppisa4lists@pikron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®