From: Chris Wedgwood <cw@f00f.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, mm-commits@vger.kernel.org
Subject: Re: + x86-move-vsyscall-page-out-of-fixmap-above-stack-tidy.patch added to -mm tree
Date: Sun, 21 May 2006 04:06:09 -0700 [thread overview]
Message-ID: <20060521110609.GA8322@taniwha.stupidest.org> (raw)
In-Reply-To: <200605210951.k4L9pwHq023019@shell0.pdx.osdl.net>
On Sun, May 21, 2006 at 02:51:54AM -0700, akpm@osdl.org wrote:
> - if ((ret = insert_vm_struct(mm, vma))) {
> + ret = insert_vm_struct(mm, vma);
> + if (ret) {
Urgh.
It's not really any cleaner/clearer so why do that?
next parent reply other threads:[~2006-05-21 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200605210951.k4L9pwHq023019@shell0.pdx.osdl.net>
2006-05-21 11:06 ` Chris Wedgwood [this message]
2006-05-21 12:09 ` Andrew Morton
2006-05-21 18:18 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060521110609.GA8322@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®