mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Andreas Dilger <adilger@clusterfs.com>,
	"Stephen C. Tweedie" <sct@redhat.com>,
	"ext2-devel@lists.sourceforge.net"
	<ext2-devel@lists.sourceforge.net>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sector_t overflow in block layer
Date: Mon, 22 May 2006 02:14:03 +0200	[thread overview]
Message-ID: <20060522001402.GB25184@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0605182307540.16178@hermes-1.csi.cam.ac.uk>

Hi!

> > Why isn't that just a 
> > 
> > 	if (unlikely(sector != (sector_t)sector))
> > 
> > and that's it? What does this have to do with CONFIG_LBD or BITS_PER_LONG, 
> > or anything at all?
> > 
> > If the sector number fits in a sector_t, we're all good.
> 
> I think you missed that Andrewas said he is worried about 64-bit overflows 
> as well.  And you would not catch those with the sector != 

Can 64-bit really overflow? That's 16 000 Peta bytes, AFAICS. Does
anyone really have disk array over 100 Peta bytes? How much space does
Google have, for example?
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      parent reply	other threads:[~2006-05-22  0:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1147849273.16827.27.camel@localhost.localdomain>
     [not found] ` <m3odxxukcp.fsf@bzzz.home.net>
     [not found]   ` <1147884610.16827.44.camel@localhost.localdomain>
     [not found]     ` <m34pzo36d4.fsf@bzzz.home.net>
     [not found]       ` <1147888715.12067.38.camel@dyn9047017100.beaverton.ibm.com>
     [not found]         ` <m364k4zfor.fsf@bzzz.home.net>
     [not found]           ` <20060517235804.GA5731@schatzie.adilger.int>
     [not found]             ` <1147947803.5464.19.camel@sisko.sctweedie.blueyonder.co.uk>
2006-05-18 18:59               ` Andreas Dilger
2006-05-18 20:58                 ` Alexey Dobriyan
2006-05-18 21:06                 ` Linus Torvalds
2006-05-18 22:12                   ` Anton Altaparmakov
2006-05-18 22:41                     ` Linus Torvalds
2006-05-18 23:23                       ` Andreas Dilger
2006-05-19 19:36                         ` Stephen C. Tweedie
2006-05-19 20:11                           ` Andrew Morton
2006-05-19 20:55                             ` Andreas Dilger
2006-05-19 21:15                               ` Andrew Morton
2006-05-19 21:05                             ` Stephen C. Tweedie
2006-05-18 22:43                     ` Andreas Dilger
2006-05-22  0:14                     ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060522001402.GB25184@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=adilger@clusterfs.com \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®