Re: [PATCH/RFC 2.6.17-rc4 1/1] ACPI: Atlas ACPI driver v2

[Pavel Machek <pavel@ucw.cz>]

Hi!

> +static int atlas_setup_input(void)
> +{
> +	int err;
> +
> +	input_dev = input_allocate_device();
> +	if (!input_dev) {
> +		printk(KERN_ERR "atlas: insufficient mem to allocate input device\n");
> +		return -ENOMEM;
> +	}
> +
> +	input_dev->name = "Atlas ACPI button driver";
> +	input_dev->phys = "acpi/input0";
> +	input_dev->id.bustype = BUS_HOST;
> +	input_dev->evbit[LONG(EV_KEY)] = BIT(EV_KEY);
> +	set_bit(KEY_F1 ,input_dev->keybit);	

", " please... and are you sure you want it as a F1..F9 keys?
> +/* button handling code */
> +static acpi_status acpi_atlas_button_setup(acpi_handle region_handle,
> +		    u32 function, void *handler_context, void **return_context)
> +{
> +	*return_context = 
> +		(function != ACPI_REGION_DEACTIVATE) ?  handler_context : NULL;

Too many spaces after ? I'd say.

> +static struct acpi_driver atlas_acpi_driver = {
> +	.name 	= ACPI_ATLAS_NAME,
> +	.class 	= ACPI_ATLAS_CLASS,
> +	.ids 	= ACPI_ATLAS_BUTTON_HID, 
> +	.ops = {
> +		.add = atlas_acpi_button_add,
> +		.remove = atlas_acpi_button_remove,
> +		},
> +};

Watch that whitespace...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html