From: Pavel Machek <pavel@ucw.cz>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
arturzaprzala@ownmail.net
Subject: Re: [PATCH] Fix typo in arch/i386/power/cpu.c
Date: Mon, 22 May 2006 19:45:07 +0200 [thread overview]
Message-ID: <20060522174507.GB2979@elf.ucw.cz> (raw)
In-Reply-To: <4471F1B7.7020203@vmware.com>
On Po 22-05-06 10:15:35, Zachary Amsden wrote:
> Fix a typo which caused us to corrupt CR2 (not likely a problem) and
> fail to restore CR0 (potentially a problem on APM systems, since TS/EM
> bits might be lost) after suspend.
> Fix a typo in suspend code noticed by Artur Zaprzala. I'm unsure if this
> actually causes a bug in practice, since the ACPI wakeup code also restores
> CR0, and the APM code returns to protected mode, but the fix is obviously much
> better.
>
> Signed-off-by: Zachary Amsden <zach@vmware.com>
I believe it is already queued in -mm tree. If you actually know know
a system it breaks (or if it breaks vmware), we have very good reason
to push it now.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2006-05-22 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 17:15 Zachary Amsden
2006-05-22 17:45 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060522174507.GB2979@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=arturzaprzala@ownmail.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®