From: David Miller <davem@davemloft.net>
To: christopher.leech@intel.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client
Date: Tue, 23 May 2006 18:13:55 -0700 (PDT) [thread overview]
Message-ID: <20060523.181355.115913162.davem@davemloft.net> (raw)
In-Reply-To: <20060524002014.19403.93371.stgit@gitlost.site>
From: Chris Leech <christopher.leech@intel.com>
Date: Tue, 23 May 2006 17:20:15 -0700
> +static void net_dma_rebalance(void)
> +{
> + unsigned int cpu, i, n;
> + struct dma_chan *chan;
> +
> + lock_cpu_hotplug();
You can't call lock_cpu_hotplug(), because that sleeps and takes
semaphores and we currently hold a spinlock taken here:
> +static void netdev_dma_event(struct dma_client *client, struct dma_chan *chan,
> + enum dma_event event)
> +{
> + spin_lock(&net_dma_event_lock);
> + switch (event) {
> + case DMA_RESOURCE_ADDED:
> + net_dma_count++;
> + net_dma_rebalance();
> + break;
You'll need to run this DMA rebalancing asynchronously in process
context via keventd or similar to deal with this locking bug.
next prev parent reply other threads:[~2006-05-24 1:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 0:16 [PATCH 0/9] I/OAT repost Chris Leech
2006-05-24 0:20 ` [PATCH 1/9] [I/OAT] DMA memcpy subsystem Chris Leech
2006-05-24 0:48 ` Andrew Morton
2006-05-24 6:31 ` Nathan Lynch
2006-05-24 0:51 ` Andrew Morton
2006-05-25 17:59 ` Olof Johansson
2006-05-25 18:09 ` Olof Johansson
2006-05-24 0:20 ` [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine Chris Leech
2006-05-24 0:56 ` Andrew Morton
2006-05-25 18:00 ` Olof Johansson
2006-05-30 23:27 ` Adrian Bunk
2006-05-24 0:20 ` [PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client Chris Leech
2006-05-24 1:13 ` David Miller [this message]
2006-05-24 0:20 ` [PATCH 4/9] [I/OAT] Utility functions for offloading sk_buff to iovec copies Chris Leech
2006-05-24 0:20 ` [PATCH 5/9] [I/OAT] Structure changes for TCP recv offload to I/OAT Chris Leech
2006-05-24 0:20 ` [PATCH 6/9] [I/OAT] Rename cleanup_rbuf to tcp_cleanup_rbuf and make non-static Chris Leech
2006-05-24 0:20 ` [PATCH 7/9] [I/OAT] make sk_eat_skb I/OAT aware Chris Leech
2006-05-24 0:20 ` [PATCH 8/9] [I/OAT] Add a sysctl for tuning the I/OAT offloaded I/O threshold Chris Leech
2006-05-24 1:02 ` Andrew Morton
2006-05-24 0:20 ` [PATCH 9/9] [I/OAT] TCP recv offload to I/OAT Chris Leech
2006-05-24 0:22 ` [PATCH 0/9] I/OAT repost David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-05-08 22:16 [PATCH 0/9] I/OAT network recv copy offload Chris Leech
2006-05-08 22:17 ` [PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client Chris Leech
2006-03-29 22:55 [PATCH 0/9] I/OAT Chris Leech
2006-03-29 22:55 ` [PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client Chris Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060523.181355.115913162.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christopher.leech@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®