From: Andrew Morton <akpm@osdl.org>
To: zippel@linux-m68k.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] restore amikbd compatibility with 2.4
Date: Wed, 24 May 2006 18:36:34 -0700 [thread overview]
Message-ID: <20060524183634.44580870.akpm@osdl.org> (raw)
In-Reply-To: <20060525003421.958272000@linux-m68k.org>
zippel@linux-m68k.org wrote:
>
> + for (i = 0; i < MAX_NR_KEYMAPS; i++) {
> + static u_short temp_map[NR_KEYS] __initdata;
> + if (!key_maps[i])
> + continue;
> + memset(temp_map, 0, sizeof(temp_map));
> + for (j = 0; j < 0x78; j++) {
> + if (!amikbd_keycode[j])
> + continue;
> + temp_map[j] = key_maps[i][amikbd_keycode[j]];
> + }
> + for (j = 0; j < NR_KEYS; j++) {
> + if (!temp_map[j])
> + temp_map[j] = 0xf200;
> + }
> + memcpy(key_maps[i], temp_map, sizeof(temp_map));
> + }
I assume temp_map[] is static to avoid using too much stack.
But wouldn't it be simpler to make this code operate on key_maps[i] directly?
next prev parent reply other threads:[~2006-05-25 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 0:27 [PATCH 00/11] various m68k patches zippel
2006-05-25 0:27 ` [PATCH 01/11] completely initialize hw_regs_t in ide_setup_ports zippel
2006-05-25 0:27 ` [PATCH 02/11] atyfb_base compile fix for CONFIG_PCI=n zippel
2006-05-25 1:33 ` Andrew Morton
2006-05-25 4:07 ` Greg KH
2006-05-25 4:28 ` Andrew Morton
2006-05-30 12:21 ` Roman Zippel
2006-05-25 0:27 ` [PATCH 03/11] cleanup unistd.h zippel
2006-05-25 0:27 ` [PATCH 04/11] Remove some unused definitions in zorro.h zippel
2006-05-25 0:27 ` [PATCH 05/11] use c99 initializer zippel
2006-05-25 0:27 ` [PATCH 06/11] print correct stack trace zippel
2006-05-25 0:27 ` [PATCH 07/11] restore amikbd compatibility with 2.4 zippel
2006-05-25 1:36 ` Andrew Morton [this message]
2006-05-25 1:50 ` Roman Zippel
2006-05-25 0:27 ` [PATCH 08/11] extra delay zippel
2006-05-25 0:27 ` [PATCH 09/11] use proper defines for zone initialization zippel
2006-05-25 0:27 ` [PATCH 10/11] adjust to changed HARDIRQ_MASK zippel
2006-05-25 0:27 ` [PATCH 11/11] m68k mac VIA2 fixes and cleanups zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060524183634.44580870.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®