From: Jean Delvare <khali@linux-fr.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>, Andrew Morton <akpm@osdl.org>
Cc: Ismail Donme <izsmail@pardus.org.tr>,
LKML <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] scx200_acb: fix section mismatch warning
Date: Thu, 25 May 2006 19:26:57 +0200 [thread overview]
Message-ID: <20060525192657.081c8c11.khali@linux-fr.org> (raw)
In-Reply-To: <20060525100138.cb9e53c5.rdunlap@xenotime.net>
Hi Randy, all,
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix section mismatch warning reported by İsmail Dönmez:
> WARNING: drivers/i2c/busses/scx200_acb.o - Section mismatch: reference
> to .init.text: from .text after 'scx200_add_cs553x' (at offset 0x528)
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/i2c/busses/scx200_acb.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc5.orig/drivers/i2c/busses/scx200_acb.c
> +++ linux-2617-rc5/drivers/i2c/busses/scx200_acb.c
> @@ -491,7 +491,7 @@ static struct pci_device_id divil_pci[]
>
> #define MSR_LBAR_SMB 0x5140000B
>
> -static int scx200_add_cs553x(void)
> +static __init int scx200_add_cs553x(void)
> {
> u32 low, hi;
> u32 smb_base;
>
Correct, I sent exactly the same patch to the the lm-sensors list and
Greg KH yesterday:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html
So this one is
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Note that the section mismatch is harmless here (we have a non-__init
function sandwiched between two __init functions) but nevertheless this
kind of warning is never welcome in a final kernel release so let's get
the fix merged now.
Andrew, can you please push this to Linus?
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-05-25 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 17:01 Randy.Dunlap
2006-05-25 17:09 ` İsmail Dönmez
2006-05-25 17:26 ` Jean Delvare [this message]
2006-05-25 18:06 ` Andrew Morton
2006-05-25 18:10 ` İsmail Dönmez
2006-05-25 18:16 ` Randy.Dunlap
2006-05-25 18:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525192657.081c8c11.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=izsmail@pardus.org.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®