From: Andrew Morton <akpm@osdl.org>
To: ak@suse.de, jbeulich@novell.com, mingo@elte.hu,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [PATCH 6/6] reliable stack trace support (i386 entry.S annotations)
Date: Fri, 26 May 2006 09:05:18 -0700 [thread overview]
Message-ID: <20060526090518.7bac4824.akpm@osdl.org> (raw)
In-Reply-To: <20060526084327.433e2be0.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
>
> Andi Kleen <ak@suse.de> wrote:
> >
> > You probably need newer binutils.
>
> Don't think so.
<fiddles a bit more>
This makes it build.
diff -puN arch/i386/kernel/entry.S~a arch/i386/kernel/entry.S
--- devel/arch/i386/kernel/entry.S~a 2006-05-26 09:02:57.000000000 -0700
+++ devel-akpm/arch/i386/kernel/entry.S 2006-05-26 09:04:08.000000000 -0700
@@ -733,6 +733,7 @@ nmi_debug_stack_check:
nmi_16bit_stack:
/* create the pointer to lss back */
+ CFI_STARTPROC simple
pushl %ss
pushl %esp
movzwl %sp, %esp
@@ -747,6 +748,7 @@ nmi_16bit_stack:
xorl %edx,%edx # zero error code
call do_nmi
RESTORE_REGS
+ CFI_ENDPROC
lss 12+4(%esp), %esp # back to 16bit stack
1: iret
.section __ex_table,"a"
@@ -756,11 +758,13 @@ nmi_16bit_stack:
KPROBE_ENTRY(int3)
pushl $-1 # mark this as an int
+ CFI_STARTPROC simple
SAVE_ALL
xorl %edx,%edx # zero error code
movl %esp,%eax # pt_regs pointer
call do_int3
jmp ret_from_exception
+ CFI_ENDPROC
.previous .text
ENTRY(overflow)
_
next prev parent reply other threads:[~2006-05-26 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 13:19 Jan Beulich
2006-05-25 5:23 ` Andrew Morton
2006-05-25 5:41 ` Andrew Morton
2006-05-26 7:00 ` Jan Beulich
2006-05-26 7:18 ` Andi Kleen
2006-05-26 15:43 ` Andrew Morton
2006-05-26 16:05 ` Andrew Morton [this message]
2006-05-26 7:26 ` Jan Beulich
2006-05-26 15:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060526090518.7bac4824.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome