mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mdharm-usb@one-eyed-alien.net,
	usb-storage@lists.one-eyed-alien.net,
	Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH][trivial] Clean up 'inline is not at beginning' warnings for usb storage
Date: Sun, 28 May 2006 19:05:14 +0200	[thread overview]
Message-ID: <200605281905.14765.jesper.juhl@gmail.com> (raw)


Usually we don't care much about 'gcc -W' warnings, but some of us do build
kernels that way to look for problems, and then the fewer warnings we have 
to wade through the better. Especially when they are very easy and 
non-intrusive to clean up. Which is the case for the following warnings 
spewed by drivers/usb/storage/usb.h :

  drivers/usb/storage/usb.h:163: warning: `inline' is not at beginning of declaration
  drivers/usb/storage/usb.h:166: warning: `inline' is not at beginning of declaration

There's also some precedence for cleaning up these warnings. I've had 
a few patches merged in the past that remove exactly this class of 
warnings.

Please consider merging.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 drivers/usb/storage/usb.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.17-rc5-git3-orig/drivers/usb/storage/usb.h	2006-05-27 13:59:08.000000000 +0200
+++ linux-2.6.17-rc5-git3/drivers/usb/storage/usb.h	2006-05-28 18:43:26.000000000 +0200
@@ -160,10 +160,10 @@
 };
 
 /* Convert between us_data and the corresponding Scsi_Host */
-static struct Scsi_Host inline *us_to_host(struct us_data *us) {
+static inline struct Scsi_Host *us_to_host(struct us_data *us) {
 	return container_of((void *) us, struct Scsi_Host, hostdata);
 }
-static struct us_data inline *host_to_us(struct Scsi_Host *host) {
+static inline struct us_data *host_to_us(struct Scsi_Host *host) {
 	return (struct us_data *) host->hostdata;
 }
 



                 reply	other threads:[~2006-05-28 17:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200605281905.14765.jesper.juhl@gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome