mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Arjan van de Ven <arjan@infradead.org>, linux-kernel@vger.kernel.org
Subject: [patch, -rc5-mm1] lock validator: fix stacktrace on x86_64
Date: Wed, 31 May 2006 14:31:56 +0200	[thread overview]
Message-ID: <20060531123156.GA9371@elte.hu> (raw)

replacement for lockdep-stacktrace-oops-workaround.patch:

------------------
Subject: lock validator: fix stacktrace on x86_64
From: Ingo Molnar <mingo@elte.hu>

after hours of hair-pulling by Arjan and me the "x86_64 crashes
on bootup" problem got traced back to a brown-paperbag 32/64-bit
mixup. Sign extension got us lucky, but that luck vanished in
2.6.17-rc5-mm1 ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 arch/x86_64/kernel/stacktrace.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/x86_64/kernel/stacktrace.c
===================================================================
--- linux.orig/arch/x86_64/kernel/stacktrace.c
+++ linux/arch/x86_64/kernel/stacktrace.c
@@ -115,9 +115,9 @@ save_context_stack(struct stack_trace *t
 	unsigned long addr;
 
 #ifdef CONFIG_FRAME_POINTER
-	unsigned prev_stack = 0;
+	unsigned long prev_stack = 0;
 
-	while (in_range(prev_stack, (unsigned long)stack, stack_end)) {
+	while (in_range(prev_stack, stack, stack_end)) {
 		pr_debug("stack:          %p\n", (void *)stack);
 		addr = (unsigned long)(((unsigned long *)stack)[1]);
 		pr_debug("addr:           %p\n", (void *)addr);

                 reply	other threads:[~2006-05-31 12:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060531123156.GA9371@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®