mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@hpl.hp.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/11] 2.6.17-rc5 perfmon2 patch for review: modified i386 files
Date: Thu, 1 Jun 2006 03:31:11 -0700	[thread overview]
Message-ID: <20060601103111.GA29421@frankl.hpl.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0605311620150.17704@scrub.home>

On Wed, May 31, 2006 at 04:21:49PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Wed, 31 May 2006, Stephane Eranian wrote:
> 
> > diff -ur linux-2.6.17-rc5.orig/arch/i386/Kconfig linux-2.6.17-rc5/arch/i386/Kconfig
> > --- linux-2.6.17-rc5.orig/arch/i386/Kconfig	2006-05-30 05:31:59.000000000 -0700
> > +++ linux-2.6.17-rc5/arch/i386/Kconfig	2006-05-30 02:48:12.000000000 -0700
> > @@ -763,6 +763,21 @@
> >  	  /sys/devices/system/cpu.
> >  
> >  
> > +menu "Hardware Performance Monitoring support"
> > +
> > +config PERFMON
> > +  	bool "Perfmon2 performance monitoring interface"
> > +	select X86_LOCAL_APIC
> > +	default y
> 
> Drop the defaults and I'm pretty sure you don't want to use select.
> 
What's wrong with 'default y' ?
Are you suggesting I use 'depends' instead of select?

Thanks.

-- 
-Stephane

  reply	other threads:[~2006-06-01 10:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31 13:52 Stephane Eranian
2006-05-31 14:21 ` Roman Zippel
2006-06-01 10:31   ` Stephane Eranian [this message]
2006-06-01 10:53     ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601103111.GA29421@frankl.hpl.hp.com \
    --to=eranian@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®