mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: anssi.hannula@gmail.com
Cc: dtor_core@ameritech.net, linux-joystick@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: input: fix comments and blank lines in new ff code
Date: Thu, 1 Jun 2006 14:33:56 -0700	[thread overview]
Message-ID: <20060601143356.f5b8d4f5.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060601204716.GA6847@delta.onse.fi>

On Thu, 1 Jun 2006 23:47:16 +0300 Anssi Hannula wrote:

> From: Anssi Hannula <anssi.hannula@gmail.com>
> 
> Fix comments so that they conform to kernel-doc or remove ** if they are
> not in kernel-doc format.
> Akso add/remove some blank lines.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
> ---
> 
> Note that the From header of my email is different as otherwise
> osdl.org would mark my email as spam. Please use my gmail.com address.

What's up with that?  OSDL filters are overly strong?


> Index: linux-2.6.17-rc4-git12/drivers/usb/input/hid-pidff.c
> ===================================================================
> --- linux-2.6.17-rc4-git12.orig/drivers/usb/input/hid-pidff.c	2006-06-01 18:51:39.000000000 +0300
> +++ linux-2.6.17-rc4-git12/drivers/usb/input/hid-pidff.c	2006-06-01 23:24:47.000000000 +0300
> @@ -914,16 +925,17 @@ static int pidff_reports_ok(struct input
>  	return 1;
>  }
>  
> -/**
> - * Find a field with a specific usage within a report
> - * @report: The report from where to find
> - * @usage: The wanted usage
> +/*
> + * pidff_find_logical_field - find a field with a specific logical usage
> + * @report: the report from where to find
> + * @usage: the wanted usage
>   * @enforce_min: logical_minimum should be 1, otherwise return NULL
>   */

Comment does not match function name.

>  static struct hid_field *pidff_find_special_field(struct hid_report *report,
>  						  int usage, int enforce_min)
>  {
>  	int i;
> +
>  	for (i = 0; i < report->maxfield; i++) {
>  		if (report->field[i]->logical == (HID_UP_PID | usage)
>  		    && report->field[i]->report_count > 0) {


And I noticed one function name _input_ff_erase().
That might be a namespace violation... anyone know the namespace
rules?

Otherwise all looks good to me.

---
~Randy

  reply	other threads:[~2006-06-01 21:31 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-30 10:57 [patch 00/12] input: force feedback updates, third time Anssi Hannula
2006-05-30 10:57 ` [patch 01/12] input: move fixp-arith.h to drivers/input Anssi Hannula
2006-05-30 10:57 ` [patch 02/12] input: fix accuracy of fixp-arith.h Anssi Hannula
2006-05-30 10:57 ` [patch 03/12] input: new force feedback interface Anssi Hannula
2006-05-31  5:21   ` Randy.Dunlap
2006-05-31 10:13     ` Anssi Hannula
2006-06-01 19:02     ` input: return -ENOSYS for registering functions when ff is disabled Anssi Hannula
2006-06-01 19:07     ` input: fix comments and blank lines in new ff code Anssi Hannula
2006-06-01 19:52       ` Randy.Dunlap
2006-06-01 20:03         ` Anssi Hannula
2006-06-01 20:09           ` Randy.Dunlap
2006-06-01 20:47             ` Anssi Hannula
2006-06-01 21:33               ` Randy.Dunlap [this message]
2006-06-01 22:16                 ` Anssi Hannula
2006-06-01 22:31                   ` Randy.Dunlap
2006-06-02 17:44                 ` [patch] input: fix function name in a comment Anssi Hannula
2006-06-05 18:52   ` [patch 03/12] input: new force feedback interface Dmitry Torokhov
2006-06-05 21:11     ` Anssi Hannula
2006-06-06  2:02       ` Dmitry Torokhov
2006-06-06 11:23         ` Anssi Hannula
2006-06-06 12:45           ` Dmitry Torokhov
2006-06-06 13:11             ` Anssi Hannula
2006-06-19 20:09               ` Anssi Hannula
2006-05-30 10:57 ` [patch 04/12] input: adapt hid force feedback drivers for the new interface Anssi Hannula
2006-05-30 10:57 ` [patch 05/12] input: adapt uinput for the new force feedback interface Anssi Hannula
2006-05-30 10:57 ` [patch 06/12] input: adapt iforce driver " Anssi Hannula
2006-05-30 10:57 ` [patch 07/12] input: force feedback driver for PID devices Anssi Hannula
2006-05-30 10:57 ` [patch 08/12] input: force feedback driver for Zeroplus devices Anssi Hannula
2006-05-30 10:57 ` [patch 09/12] input: update documentation of force feedback Anssi Hannula
2006-05-30 10:57 ` [patch 10/12] input: drop the remains of the old ff interface Anssi Hannula
2006-05-30 10:57 ` [patch 11/12] input: drop the old PID driver Anssi Hannula
2006-05-30 10:57 ` [patch 12/12] input: use -ENOSPC instead of -ENOMEM in iforce when device full Anssi Hannula
2006-05-31  5:02   ` Randy.Dunlap
2006-05-31 10:04     ` Anssi Hannula
2006-05-31 15:15       ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601143356.f5b8d4f5.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@osdl.org \
    --cc=anssi.hannula@gmail.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®