From: Pavel Machek <pavel@ucw.cz>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
Date: Sat, 3 Jun 2006 23:30:11 +0200 [thread overview]
Message-ID: <20060603213011.GA20523@elf.ucw.cz> (raw)
In-Reply-To: <4481F9B3.2020703@gmail.com>
Hi!
> >>From: Catalin Marinas <catalin.marinas@arm.com>
> >>+ memleak_debug_not_leak(res);
> >
> > I'd suggest some shorter/more generic name.
> >
> > not_freed(res); ?
> >
> > alloc_forever(res); ?
>
> It's true that the names are a bit long ("debug" is even superfluous). I
> would, however, keep the memleak_ prefix as I think it makes the code
> clearer (i.e. the function belongs to a certain part of the kernel).
Well, in future some other leak detector may want to use these hooks.
Anyway memleak_not_leak() is already quite good.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-06-03 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 8:10 [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.4 Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 1/8] Base support for kmemleak Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 2/8] Some documentation " Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 3/8] Add the memory allocation/freeing hooks " Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 4/8] Modules support " Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 5/8] Add kmemleak support for i386 Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 6/8] Add kmemleak support for ARM Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives Catalin Marinas
2006-06-03 20:48 ` Pavel Machek
2006-06-03 21:05 ` Catalin Marinas
2006-06-03 21:30 ` Pavel Machek [this message]
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 8/8] Simple testing for kmemleak Catalin Marinas
2006-06-04 21:56 [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.5 Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060603213011.GA20523@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®