From: Andrew Morton <akpm@osdl.org>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [patch] i386: print NUMA in oops messages
Date: Mon, 5 Jun 2006 21:18:55 -0700 [thread overview]
Message-ID: <20060605211855.d92dab53.akpm@osdl.org> (raw)
In-Reply-To: <200606052303_MC3-1-C1B2-7E2C@compuserve.com>
On Mon, 5 Jun 2006 23:01:14 -0400
Chuck Ebbert <76306.1226@compuserve.com> wrote:
> + printk(
> #ifdef CONFIG_PREEMPT
> - printk("PREEMPT ");
> + "PREEMPT "
> #endif
> #ifdef CONFIG_SMP
> - printk("SMP ");
> + "SMP "
> +#endif
> +#ifdef CONFIG_NUMA
> + "NUMA "
> #endif
> #ifdef CONFIG_DEBUG_PAGEALLOC
> - printk("DEBUG_PAGEALLOC");
> + "DEBUG_PAGEALLOC"
> #endif
> - printk("\n");
> + "\n");
> +
This is too cute for my taste. Keep it simple.
I suppose one could do something like
static const char config_string[] = ""
#ifdef CONFIG_SMP
" SMP"
#endif
#ifdef CONFIG_NUMA
" NUMA"
#endif
;
if one really feels so motivated...
next prev parent reply other threads:[~2006-06-06 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 3:01 Chuck Ebbert
2006-06-06 4:18 ` Andrew Morton [this message]
2006-06-06 4:54 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605211855.d92dab53.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®