From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751060AbWFFVRj@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751060AbWFFVRj (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 6 Jun 2006 17:17:39 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751120AbWFFVRj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 6 Jun 2006 17:17:39 -0400
Received: from xenotime.net ([66.160.160.81]:27079 "HELO xenotime.net")
	by vger.kernel.org with SMTP id S1751060AbWFFVRi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Jun 2006 17:17:38 -0400
Date: Tue, 6 Jun 2006 14:20:22 -0700
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: paulkf@microgate.com, davej@redhat.com, akpm@osdl.org,
       linux-kernel@vger.kernel.org, zippel@linux-m68k.org
Subject: Re: [PATCH] fix missing hdlc symbols for synclink drivers
Message-Id: <20060606142022.b184d1c5.rdunlap@xenotime.net>
In-Reply-To: <m3lksac7op.fsf@defiant.localdomain>
References: <20060603232004.68c4e1e3.akpm@osdl.org>
	<20060605230248.GE3963@redhat.com>
	<20060605184407.230bcf73.rdunlap@xenotime.net>
	<1149622813.11929.3.camel@amdx2.microgate.com>
	<m3u06yc9mr.fsf@defiant.localdomain>
	<4485E723.4070201@microgate.com>
	<m3lksac7op.fsf@defiant.localdomain>
Organization: YPO4
X-Mailer: Sylpheed version 2.2.5 (GTK+ 2.8.3; x86_64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 06 Jun 2006 23:09:42 +0200 Krzysztof Halasa wrote:

> Paul Fulghum <paulkf@microgate.com> writes:
> 
> > If I took that approach then you could never
> > use the synclink drivers without generic HDLC.
> >
> > The synclink drivers can be used independent of
> > the generic HDLC or with generic HDLC depending
> > on space requirements and application.
> 
> Ah, now I understand. Anyway, the Makefile is not related to the problem.
> 
> > If you can provide a patch that continues allowing
> > that level of flexibility in a way more to
> > your liking, then please post it and I'll have a look.
> 
> I think I would modify the conditionals in drivers/char/synclink.c
> - to assume that generic HDLC is not present if CONFIG_SYNCLINK=y
> and CONFIG_HDLC=m. I would even put a user-visible comment in the
> *config (like the one in generic HDLC menu if you have no X.25/LAPB).
> 
> I.e., I would probably change:
> 
> #ifdef CONFIG_HDLC_MODULE
> #define CONFIG_HDLC 1
> #endif
> 
> into something like:
> 
> #if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
> #define CONFIG_HDLC 1
> #endif

So SYNCLINK has different capabilities depending on whether
HDLC=m or HDLC=y ??
Makes no sense to me, but I'll leave it to you and Paul.

> plus that comment in Kconfig.
> 
> (Not sure if the other synclink*.c files are relevant and need similar
> changes).
> -- 
> Krzysztof Halasa


---
~Randy