mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Don Zickus <dzickus@redhat.com>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
	Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>,
	shaohua.li@intel.com, miles.lane@gmail.com, jeremy@goop.org,
	linux-kernel@vger.kernel.org, Pavel Machek <pavel@suse.cz>
Subject: Re: [2.6.17-rc5-mm2] crash when doing second suspend: BUG in arch/i386/kernel/nmi.c:174
Date: Wed, 7 Jun 2006 11:55:38 +0200	[thread overview]
Message-ID: <200606071155.38701.rjw@sisk.pl> (raw)
In-Reply-To: <20060607004217.GF11696@redhat.com>

Hi,

On Wednesday 07 June 2006 02:42, Don Zickus wrote:
> On Wed, Jun 07, 2006 at 10:05:07AM +1000, Nigel Cunningham wrote:
> > On Wednesday 07 June 2006 09:55, Don Zickus wrote:
> > > > > So my question is/was what is the proper way to handle processor level
> > > > > subsystems during the suspend/resume path on an SMP system.  I really
> > > > > don't understand the hotplug path nor the suspend/resume path very
> > > > > well.
> > > >
> > > > Make it work properly for CPU hotplug for individual CPU and then in
> > > > suspend you take care of "global" state and the last CPU.
> > >
> > > So the assumption is treat all the cpus the same either all on or all off,
> > > no mixed mode (some cpus on, some cpus off).  I guess I was trying to hard
> > > to work on the per-cpu level.
> > 
> > This sounds wrong to me. Shouldn't the the effect of hotunplugging a cpu be to 
> > put the driver in a state equivalent to if that cpu simply didn't exist? 
> > Unplugging shouldn't assume we're going to subsequently have either a driver 
> > suspend, or a replug.
> 
> This is my biggest problem or maybe my complete lack of understanding, is
> that I don't know how to determine what state I am in during a hotplug
> event, either a cpu removal or a suspend.  Therefore I feel like I have to
> store some persistant data around _just_ in case this is a suspend event.
> Also at the opposite end, how to separate a cpu insert vs. a cpu resume.
> The different being initialize to a global state vs. initialize to a last
> known state.

The original idea was to treat the nonboot CPUs as though they were removed.

Greetings,
Rafael

  parent reply	other threads:[~2006-06-07  9:55 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-02 22:51 Jeremy Fitzhardinge
2006-06-04 11:47 ` Rafael J. Wysocki
2006-06-05  7:21   ` Jeremy Fitzhardinge
2006-06-05  7:37 ` Jeremy Fitzhardinge
2006-06-05  7:48   ` Andrew Morton
2006-06-05  7:59     ` Jeremy Fitzhardinge
2006-06-05  8:35     ` Miles Lane
2006-06-06  6:44       ` Shaohua Li
2006-06-06 14:17         ` Don Zickus
2006-06-06 14:18           ` Andi Kleen
2006-06-06 21:45             ` Don Zickus
2006-06-06 22:15               ` Andrew Morton
2006-06-06 23:05                 ` Don Zickus
2006-06-06 23:22                   ` Andrew Morton
2006-06-06 23:27                     ` Jeremy Fitzhardinge
2006-06-06 23:32                       ` Andi Kleen
2006-06-06 23:42                       ` Don Zickus
2006-06-08 20:11                         ` Pavel Machek
2006-06-06 23:38                     ` Nigel Cunningham
2006-06-07  0:06                       ` Jeremy Fitzhardinge
2006-06-07  0:13                         ` Nigel Cunningham
2006-06-07  0:24                           ` Andrew Morton
2006-06-07  0:29                             ` Jeremy Fitzhardinge
2006-06-07  0:31                             ` Nigel Cunningham
2006-06-07  0:33                             ` Andi Kleen
2006-06-07  0:40                               ` Nigel Cunningham
2006-06-07  0:26                           ` Jeremy Fitzhardinge
2006-06-07  0:33                             ` Nigel Cunningham
2006-06-07  0:56                               ` Jeremy Fitzhardinge
2006-06-08 20:13                         ` Pavel Machek
2006-06-08 12:45                     ` Pavel Machek
2006-06-06 23:34                   ` Andi Kleen
2006-06-06 23:55                     ` Don Zickus
2006-06-07  0:04                       ` Andi Kleen
2006-06-07  0:05                       ` Nigel Cunningham
2006-06-07  0:42                         ` Don Zickus
2006-06-07  0:50                           ` Nigel Cunningham
2006-06-07  3:29                             ` [linux-pm] " David Brownell
2006-06-07  9:55                           ` Rafael J. Wysocki [this message]
2006-06-08 20:27                           ` Pavel Machek
2006-06-06 16:23         ` Jeremy Fitzhardinge
2006-06-06 16:51           ` Don Zickus
2006-06-07  2:49           ` Don Zickus
2006-06-07 16:33             ` Andi Kleen
2006-06-07 17:07             ` Jeremy Fitzhardinge
2006-06-07 17:50               ` Don Zickus
2006-06-07 18:53                 ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606071155.38701.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=dzickus@redhat.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=ncunningham@linuxmail.org \
    --cc=pavel@suse.cz \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome